Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPIK-210] Fix NPE in batch endpoint when project name is null #351

Conversation

thiagohora
Copy link
Contributor

@thiagohora thiagohora commented Oct 4, 2024

Details

Fixing NPE:

error.stack:    at java.base/java.util.Objects.requireNonNull(Objects.java:259)
    at reactor.core.publisher.FluxIterable$IterableSubscription.slowPath(FluxIterable.java:322)
    at reactor.core.publisher.FluxIterable$IterableSubscription.request(FluxIterable.java:294)
    at reactor.core.publisher.FluxFlatMap$FlatMapMain.onSubscribe(FluxFlatMap.java:373)
    at reactor.core.publisher.FluxIterable.subscribe(FluxIterable.java:201)
    at reactor.core.publisher.FluxIterable.subscribe(FluxIterable.java:83)
    at reactor.core.publisher.Mono.subscribe(Mono.java:4512)
    at reactor.core.publisher.MonoSubscribeOn$SubscribeOnSubscriber.run(MonoSubscribeOn.java:126)
    at reactor.core.scheduler.WorkerTask.call(WorkerTask.java:84)
    at reactor.core.scheduler.WorkerTask.call(WorkerTask.java:37)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
    at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
    at java.base/java.lang.Thread.run(Thread.java:1583)

Also, the usage test was adjusted to avoid failure locally when the container is up for more than a day.

Issues

OPIK-210

@thiagohora thiagohora requested a review from a team as a code owner October 4, 2024 13:38
@thiagohora thiagohora self-assigned this Oct 4, 2024
@thiagohora thiagohora force-pushed the thiagohora/OPIK-210_fix_npe_in_batch_endpoint_when_project_name_is_null branch from e70652f to b69308e Compare October 4, 2024 13:58
Copy link
Collaborator

@andrescrz andrescrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@thiagohora thiagohora merged commit b4b57d1 into main Oct 7, 2024
7 checks passed
@thiagohora thiagohora deleted the thiagohora/OPIK-210_fix_npe_in_batch_endpoint_when_project_name_is_null branch October 7, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants