-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPIK-135] Add support to RDS auth for MySQL #306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! what additional parameters do we add for URL ? i think its cleaner to have an additional config and not url changes. but this looks ok for now
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hi @andrescrz and @Nimrod007, The E2E tests are failing because the variable changes are not backward compatible.
|
Thanks for letting us know. This would've passed if the end 2 end tests Github action was using an image containing the changes in the PR instead of the latest main version. |
…github.com/comet-ml/opik into OPIK-135/add_support_to_aws_rds_auth_mysql
ca326b4
Added disbaled test to help/test setup |
* [OPIK-135] Add support to RDS auth for MySQL * Change variables * Update Helm documentation * Add AWS tests --------- Co-authored-by: CometActions <[email protected]>
Details
Issues
OPIK-135
Testing
Locally, assuming a ROLE with the required access to RDS.
Documentation
In order to enable the Authentication using the AWS IAM mechanism, the user needs the following:
AWSAuthenticationPlugin
as authentication mode for the target MySQL user. See link.software.amazon.jdbc.Driver
instead ofcom.mysql.cj.jdbc.Driver
STATE_DB_PROTOCOL
to update the connection string. Usejdbc:aws-wrapper:mysql://
instead ofjdbc:mysql://
STATE_DB_PLUGINS
toiam
or other valid plugins. For more valid options, see linkSTATE_DB_PASS
to empty.