add opik.config unit tests #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkuzmik
reviewed
Sep 19, 2024
alexkuzmik
reviewed
Sep 20, 2024
alexkuzmik
requested changes
Sep 20, 2024
There was a problem hiding this comment.
@japdubengsub good coverage! I tried to break the logic in a few places and the tests caught it 👍
One thing that you should change - make sure that your tests are isolated from the real environment.
In my local dev setup for example I have OPIK_URL_OVERRIDE=http://localhost:5173/api environment variable specified for tests. Some of your tests fail because this environment variable affected OpikConfig.
I recommend replacing real OpikConfig instance with a fake one via mock/fixture.
alexkuzmik
approved these changes
Sep 23, 2024
dsblank
pushed a commit
that referenced
this pull request
Oct 4, 2024
* add unit test * add unit test part II * add unit test part III * add unit test part IV * add unit test part V * add unit test part VII * add unit test chapter VIII * add unit test chapter IX * add unit test chapter XI * add unit test chapter XII * add mock for env vars and config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Added a set of unit tests for the configure() method and the objects it uses. Performed a medium refactoring to make writing unit tests easier.