Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPIK-72 Make experiment name optional #267

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

andrescrz
Copy link
Collaborator

@andrescrz andrescrz commented Sep 17, 2024

Details

Allowing null/empty/blank experiment name. In that case, a random one is generated with the same algorithm and values as a Comet Experiment.

Issues

OPIK-72

Testing

  • Updated integration tests covering:

    • Name is provided.
    • Name is randomly generated if null/empty/blank is provided.
  • Manually tested in the service by curling the endpoint without a name and both curling the generated name and checking it in the UI.

Documentation

N/A

@andrescrz andrescrz self-assigned this Sep 17, 2024
@andrescrz andrescrz marked this pull request as ready for review September 17, 2024 16:25
@andrescrz andrescrz requested a review from a team as a code owner September 17, 2024 16:25
@andrescrz andrescrz added the enhancement New feature or request label Sep 18, 2024
Copy link
Contributor

@thiagohora thiagohora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrescrz andrescrz merged commit 62c00c0 into main Sep 18, 2024
2 checks passed
@andrescrz andrescrz deleted the andrescrz/OPIK-103-make-experiment-name-optional branch September 18, 2024 10:30
dsblank pushed a commit that referenced this pull request Oct 4, 2024
* OPIK-72 Make experiment name optional

* Rev2: fixed wrong import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants