Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NA] Fix style issues #251

Merged
merged 1 commit into from
Sep 16, 2024
Merged

[NA] Fix style issues #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions apps/opik-backend/src/main/java/com/comet/opik/api/resources/v1/priv/SpansResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
import java.util.stream.Collectors;

import static com.comet.opik.api.Span.SpanPage;
import static com.comet.opik.api.Span.View;
import static com.comet.opik.utils.AsyncUtils.setRequestContext;
import static com.comet.opik.utils.ValidationUtils.validateProjectNameAndProjectId;

Expand All @@ -73,7 +72,7 @@ public class SpansResource {
@GET
@Operation(operationId = "getSpansByProject", summary = "Get spans by project_name or project_id and optionally by trace_id and/or type", description = "Get spans by project_name or project_id and optionally by trace_id and/or type", responses = {
@ApiResponse(responseCode = "200", description = "Spans resource", content = @Content(schema = @Schema(implementation = SpanPage.class)))})
@JsonView(View.Public.class)
@JsonView(Span.View.Public.class)
public Response getByProjectId(
@QueryParam("page") @Min(1) @DefaultValue("1") int page,
@QueryParam("size") @Min(1) @DefaultValue("10") int size,
Expand Down Expand Up @@ -108,7 +107,7 @@ public Response getByProjectId(
@Operation(operationId = "getSpanById", summary = "Get span by id", description = "Get span by id", responses = {
@ApiResponse(responseCode = "200", description = "Span resource", content = @Content(schema = @Schema(implementation = Span.class))),
@ApiResponse(responseCode = "404", description = "Not found", content = @Content(schema = @Schema(implementation = Span.class)))})
@JsonView(View.Public.class)
@JsonView(Span.View.Public.class)
public Response getById(@PathParam("id") @NotNull UUID id) {

String workspaceId = requestContext.get().getWorkspaceId();
Expand All @@ -128,7 +127,7 @@ public Response getById(@PathParam("id") @NotNull UUID id) {
@ApiResponse(responseCode = "201", description = "Created", headers = {
@Header(name = "Location", required = true, example = "${basePath}/v1/private/spans/{spanId}", schema = @Schema(implementation = String.class))})})
public Response create(
@RequestBody(content = @Content(schema = @Schema(implementation = Span.class))) @JsonView(View.Write.class) @NotNull @Valid Span span,
@RequestBody(content = @Content(schema = @Schema(implementation = Span.class))) @JsonView(Span.View.Write.class) @NotNull @Valid Span span,
@Context UriInfo uriInfo) {

String workspaceId = requestContext.get().getWorkspaceId();
Expand Down
2 changes: 1 addition & 1 deletion apps/opik-backend/src/main/java/com/comet/opik/domain/ExperimentItemService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public class ExperimentItemService {
private final @NonNull ExperimentService experimentService;
private final @NonNull DatasetItemDAO datasetItemDAO;

public Mono<Void> create(@NonNull Set<ExperimentItem> experimentItems) {
public Mono<Void> create(Set<ExperimentItem> experimentItems) {
Preconditions.checkArgument(CollectionUtils.isNotEmpty(experimentItems),
"Argument 'experimentItems' must not be empty");

Expand Down