Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPIK-86] Change layout for get started page #241

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

ferc
Copy link
Collaborator

@ferc ferc commented Sep 13, 2024

Details

  • Change layout for the Get Started page
  • Fix link area to be only clickable in the demo project card
  • Add responsiveness in the card
  • Redirect to a new tab in case user clicks into the demo project card
    Screenshot 2024-09-13 at 5 53 53 PM

Issues

Resolves #

Testing

Documentation

@ferc ferc requested a review from a team as a code owner September 13, 2024 15:55
@ferc ferc force-pushed the ferc/OPIK-86-get-started-tweaks branch from cc4286e to e9d1906 Compare September 13, 2024 16:15
Copy link
Contributor

@andriidudar andriidudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

import { Link, Outlet } from "@tanstack/react-router";
import imageLogoUrl from "/images/logo_and_text.png";

const PageLayout = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to rename the component with your next PR.

@andriidudar andriidudar merged commit b32d4f5 into main Sep 13, 2024
1 check passed
@andriidudar andriidudar deleted the ferc/OPIK-86-get-started-tweaks branch September 13, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants