OPIK-75 Batch traces creation endpoint #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5_batch_traces_creation
…5_batch_traces_creation
andrescrz
approved these changes
Sep 13, 2024
| :workspace_id, | ||
| :name<item.index>, | ||
| parseDateTime64BestEffort(:start_time<item.index>, 9), | ||
| if(:end_time<item.index> IS NULL, NULL, parseDateTime64BestEffort(:end_time<item.index>, 9)), |
There was a problem hiding this comment.
Minor: parseDateTimeBestEffortUSOrNull can be used:
Comment on lines
+739
to
+741
| public Mono<Long> batchInsert(@NonNull List<Trace> traces, @NonNull Connection connection) { | ||
|
|
||
| Preconditions.checkArgument(!traces.isEmpty(), "traces must not be empty"); |
There was a problem hiding this comment.
Minor: non-null and empty can be done in one go by removing the non-null annotation and using CollectionUtils.IsNotEmpty.
Comment on lines
+89
to
+91
| public Mono<Long> create(TraceBatch batch) { | ||
|
|
||
| Preconditions.checkArgument(!batch.traces().isEmpty(), "Batch traces cannot be empty"); |
There was a problem hiding this comment.
Minor risk of NPE: better use CollectionUtils.isNotEmpty.
Comment on lines
+127
to
+129
| private Mono<Project> resolveProject(String projectName) { | ||
| return getOrCreateProject(WorkspaceUtils.getProjectName(projectName)); | ||
| } |
There was a problem hiding this comment.
Minor: kind of pointless method, it can be removed.
| import java.util.UUID; | ||
|
|
||
| @UtilityClass | ||
| public class TestUtils { |
There was a problem hiding this comment.
Minor: better use a more specific name for this class. Having said that, this is a nice change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Add endpoint to batch create traces.
POST /v1/private/spans/batch
Issues
Resolves #
Testing
Documentation