Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the project version.txt as fallback for SDK version #224

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

dsblank
Copy link
Contributor

@dsblank dsblank commented Sep 11, 2024

Details

  1. Use envionment "VERSION" if it exists
  2. Else, uses version.txt file contents
  3. Else, uses 0.0.1

Issues

Resolves #166

Testing

Tested all three scenarios

Documentation

None

@dsblank dsblank requested a review from a team as a code owner September 11, 2024 20:56
@dsblank
Copy link
Contributor Author

dsblank commented Sep 11, 2024

Also, makes it possible to install from other directories, like:

pip install -e sdks/python

which didn't work before.

alexkuzmik
alexkuzmik previously approved these changes Sep 12, 2024
@alexkuzmik
Copy link
Collaborator

@dsblank approved, but please run pre-commit run --all-files to fix lint errors (from sdks/python folder).

@dsblank dsblank force-pushed the dsb/use-project-version-fallback branch from 724dd7e to baf6fb5 Compare September 12, 2024 11:53
@dsblank dsblank requested a review from alexkuzmik September 12, 2024 12:00
@dsblank dsblank self-assigned this Sep 12, 2024
@alexkuzmik alexkuzmik merged commit 5f87b3e into main Sep 12, 2024
6 checks passed
@alexkuzmik alexkuzmik deleted the dsb/use-project-version-fallback branch September 12, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing opik SDK in editable mode always gives version 0.0.1
2 participants