-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO-JIRA] Span/trace creations in the end of functions execution #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scores are logged when trace/span is created. Adjust update_current_span and update_current_trace to accept feedback scores as well
japdubengsub
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR changes the way
track
functionality works. Now CreateSpan or CreateTrace messages are generated and scheduled to be sent to the backend when the tracked function finishes working (before that CreateMessage was generated when the function began, UpdateMessage when it was ending).Now UpdateSpan/UpdateTrace requests are sent to the backend only if you are using low-level api (which is still working as before).
The changes in the API and UX:
get_current_span()
andget_current_trace()
functions were removed. You can now useget_current_span_data()
,get_current_trace_data()
to get information accumulated for sending in the end of the current function. If you want to update it, you can useupdate_current_span()
,update_current_trace()
. All these functions are stored inopik.opik_context
namespace.Implementation changes (high-level).
span.Span
,trace.Trace
api objects, but withspan.SpanData
,trace.TraceData
. Those objects have no methods that trigger any requests, they are simply dataclasses instances that store information about trace and span to be created. So, any part of the SDK that uses context_storage (oropik_context
) has been adjusted accordingly.Integrations:
I've updated the langchain integration, llama_index integration already. Other ones should be checked in case they are affected and updated accordingly.