Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for clickhouse loadbalancer #220

Merged
merged 3 commits into from
Sep 11, 2024
Merged

fix for clickhouse loadbalancer #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
080810e
fix for clickhouse loadbalancer
liyaka Sep 11, 2024
fd7800a
small helm docs update
liyaka Sep 11, 2024
451b79c
Update Helm documentation
CometActions Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions deployment/helm_chart/opik/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,7 @@ helm repo add bitnami https://charts.bitnami.com/bitnami
helm dependency build
VERSION=0.1.0
helm upgrade --install opik -n opik --create-namespace -f values.yaml \
--set component.backend.image.tag=$VERSION --set component.frontend.image.tag=$VERSION \
--set component.backend.env.ANALYTICS_DB_MIGRATIONS_PASS=opik --set component.backend.env.ANALYTICS_DB_PASS=opik \
--set component.backend.env.STATE_DB_PASS=opik
--set component.backend.image.tag=$VERSION --set component.frontend.image.tag=$VERSION
```

## Open application
Expand Down
4 changes: 1 addition & 3 deletions deployment/helm_chart/opik/README.md.gotmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,7 @@ helm repo add bitnami https://charts.bitnami.com/bitnami
helm dependency build
VERSION=0.1.0
helm upgrade --install opik -n opik --create-namespace -f values.yaml \
--set component.backend.image.tag=$VERSION --set component.frontend.image.tag=$VERSION \
--set component.backend.env.ANALYTICS_DB_MIGRATIONS_PASS=opik --set component.backend.env.ANALYTICS_DB_PASS=opik \
--set component.backend.env.STATE_DB_PASS=opik
--set component.backend.image.tag=$VERSION --set component.frontend.image.tag=$VERSION
```

## Open application
Expand Down
18 changes: 9 additions & 9 deletions deployment/helm_chart/opik/templates/clickhouseinstallation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,13 @@ metadata:
component: clickhouse
{{- include "opik.labels" $ | nindent 4 }}
spec:
defaults:
templates:
podTemplate: clickhouse-cluster-pod-template
serviceTemplate: {{ .Values.clickhouse.service.serviceTemplate }}
volumeClaimTemplate: storage-vc-template
configuration:
users:
# TODO change for local
{{- if .Values.clickhouse.adminUser.useSecret.enabled }}
{{ .Values.clickhouse.adminUser.username }}/k8s_secret_password: {{ include "opik.name" .}}-{{ .Values.clickhouse.adminUser.secretname }}/{{ .Values.clickhouse.adminUser.password_key }}
{{- else }}
Expand All @@ -31,12 +35,12 @@ spec:
shardsCount: {{ .Values.clickhouse.shardsCount }}
replicasCount: {{ .Values.clickhouse.replicasCount }}
templates:
podTemplate: clickhouse-stable
podTemplate: clickhouse-cluster-pod-template
serviceTemplate: {{ .Values.clickhouse.service.serviceTemplate }}
volumeClaimTemplate: storage-vc-template
templates:
podTemplates:
- name: clickhouse-stable
- name: clickhouse-cluster-pod-template
spec:
containers:
- name: clickhouse
Expand Down Expand Up @@ -71,8 +75,10 @@ spec:
ports:
- name: http
port: 8123
targetPort: 8123
- name: tcp
port: 9000
targetPort: 9000
type: LoadBalancer

volumeClaimTemplates:
Expand All @@ -86,9 +92,3 @@ spec:
resources:
requests:
storage: {{ .Values.clickhouse.storage }}

defaults:
templates:
podTemplate: clickhouse-cluster-pod-template
serviceTemplate: clickhouse-cluster-svc-template