[OPIK-37] [UX Improvement] Move experiments to separate page #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriidudar
force-pushed
the
andriidudar/OPIK-37-experiments-page
branch
from
7fbf51b to
76777dc
Compare
andrescrz
approved these changes
Sep 11, 2024
andrescrz
reviewed
Sep 11, 2024
| experimentsIds.length === 1 | ||
| ? experiment?.name | ||
| : `Compare (${experimentsIds.length})`; | ||
| const noDataText = "There are no data for selected experiments"; |
There was a problem hiding this comment.
Minor and not a blocker: We need to double check the correct writing in English:
There are no data... vs There's no data....
From the dictionary:
USAGE
In Latin, data is the plural of datum and, historically and in specialized scientific fields, it is also treated as a plural in English, taking a plural verb, as in ‘the data were collected and classified’. In modern non-scientific use, however, it is generally not treated as a plural. Instead, it is treated as a mass noun, similar to a word like information, which takes a singular verb. Sentences such as ‘data was collected over a number of years’ are now widely accepted in standard English
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Issues
Resolves #
Testing
Documentation