NO-JIRA Missing now64 precision of 9 #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohora
reviewed
Sep 10, 2024
| @@ -155,7 +154,7 @@ INSERT INTO spans( | |||
| :metadata as metadata, | |||
| :tags as tags, | |||
| mapFromArrays(:usage_keys, :usage_values) as usage, | |||
| now64() as created_at, | |||
| now64(9) as created_at, | |||
There was a problem hiding this comment.
It gets truncated by the column, no?
There was a problem hiding this comment.
It just uses the default, which is 3 (milliseconds) whereas everywhere else we use 9 (nanoseconds). See:
thiagohora
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Minor bug discovered during the query plan analysis task.
The Span creation endpoint was not setting the proper precision for
created_atfield.Fixed by adding precision 9 to the
now64call.Additionally, run spotless to fix formatting issues.
Issues
N/A
Testing
Documentation
N/A