-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NA] Simplify data ingestion for dataset and experiment items #191
Merged
andrescrz
merged 12 commits into
main
from
thiagohora/simplify_data_ingestion_for_dataset_and_experiment_items
Sep 6, 2024
Merged
[NA] Simplify data ingestion for dataset and experiment items #191
andrescrz
merged 12 commits into
main
from
thiagohora/simplify_data_ingestion_for_dataset_and_experiment_items
Sep 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub.com/comet-ml/opik into thiagohora/add_new_relic_instrumentation
…et_and_experiment_items
thiagohora
changed the title
Thiagohora/simplify data ingestion for dataset and experiment items
[NA] Simplify data ingestion for dataset and experiment items
Sep 6, 2024
LifeXplorer
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
andrescrz
approved these changes
Sep 6, 2024
<if(item.hasNext)> | ||
UNION ALL | ||
, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer like this since multiple rows are allowed in a single statement:
andrescrz
deleted the
thiagohora/simplify_data_ingestion_for_dataset_and_experiment_items
branch
September 6, 2024 14:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Issues
Resolves #
Testing
Documentation