Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NA: Add missing cache for sdk auth #184

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

thiagohora
Copy link
Contributor

Details

Issues

Resolves #

Testing

Documentation

@thiagohora thiagohora requested a review from a team as a code owner September 5, 2024 09:45
@thiagohora thiagohora self-assigned this Sep 5, 2024
LifeXplorer
LifeXplorer previously approved these changes Sep 5, 2024
Copy link

@LifeXplorer LifeXplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@thiagohora thiagohora force-pushed the thiagohora/add_cache_to_api_key_auth branch from 73877f1 to 2ff2e65 Compare September 5, 2024 10:55
@@ -11,6 +10,5 @@ public class BulkOperationsConfig {

@Valid
@JsonProperty
@NotNull
private int size;
@NotNull private int size;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: int primitive can't be null.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove in the next PR

@thiagohora thiagohora merged commit f9c054e into main Sep 5, 2024
2 checks passed
@thiagohora thiagohora deleted the thiagohora/add_cache_to_api_key_auth branch September 5, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants