[OPIK-695] sdk sentry integration #1045
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… invalid workspace value was passed once
japdubengsub
approved these changes
Jan 14, 2025
|
|
||
|
|
||
| class FilterByCount(event_filter.EventFilter): | ||
| def __init__(self, max_count: int, level: str): |
There was a problem hiding this comment.
I guess there are only a few specific level values. Maybe we could we use Literal instead of str here?
There was a problem hiding this comment.
Good idea, will do!
|
|
||
| @functools.lru_cache | ||
| def randomized_should_enable_reporting() -> bool: | ||
| return random.random() <= SESSION_REPORTING_PROBABILITY |
There was a problem hiding this comment.
It seems that this func always returns True?
There was a problem hiding this comment.
Yes, in case we need to randomly sample user sessions which will have reporting enabled, we'll reduce the session reporting probability constant value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Added errors reporting to Sentry.
Unhandled errors inherited from
opik.rest_api.core.ApiErrorandopik.exceptions.OpikExceptionare reported to Sentry together with all Opik log messages with levels "error" and "warning".Client-side configured event limits per python session - 50 warnings and 50 errors.
Testing
Unit tests are added for some sentry setup logic (logger setup + filters chain setup).
Some manual tests are performed.