Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPIK-751] Use Mustache for online scoring #1043

Merged
merged 10 commits into from
Jan 15, 2025

Conversation

thiagohora
Copy link
Contributor

Details

Add Mustache as the template engine for online scoring

Issues

OPIK-751

…rom_traces

# Conflicts:
#	apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderAnthropic.java
#	apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderOpenAi.java
#	apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderService.java
Fixing missing traceId in the score when we moved into the batch storing.
@thiagohora thiagohora requested a review from a team as a code owner January 14, 2025 14:27
@thiagohora thiagohora self-assigned this Jan 14, 2025
@thiagohora thiagohora force-pushed the thiagohora/OPIK-751_use_Mustache_for_online_scoring branch from c3a66b0 to b93f45b Compare January 14, 2025 14:30
Base automatically changed from daniel/OPIK-594-trigger_scoring_from_traces to main January 14, 2025 16:25
@thiagohora thiagohora force-pushed the thiagohora/OPIK-751_use_Mustache_for_online_scoring branch from e6b1247 to d704396 Compare January 15, 2025 08:16
ldaugusto
ldaugusto previously approved these changes Jan 15, 2025
Copy link
Contributor

@ldaugusto ldaugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is totally fine. It'd be good to see a test showing some corner cases the non-mustache solution wasn't capable to render, like a template variable starting/ending with whitespaces.

Copy link
Contributor

@ldaugusto ldaugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@thiagohora thiagohora merged commit de08570 into main Jan 15, 2025
8 checks passed
@thiagohora thiagohora deleted the thiagohora/OPIK-751_use_Mustache_for_online_scoring branch January 15, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants