-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPIK-751] Use Mustache for online scoring #1043
[OPIK-751] Use Mustache for online scoring #1043
Conversation
…rom_traces # Conflicts: # apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderAnthropic.java # apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderOpenAi.java # apps/opik-backend/src/main/java/com/comet/opik/domain/llmproviders/LlmProviderService.java
Fixing missing traceId in the score when we moved into the batch storing.
c3a66b0
to
b93f45b
Compare
e6b1247
to
d704396
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is totally fine. It'd be good to see a test showing some corner cases the non-mustache solution wasn't capable to render, like a template variable starting/ending with whitespaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Details
Add Mustache as the template engine for online scoring
Issues
OPIK-751