Skip to content

Commit

Permalink
Config renamings
Browse files Browse the repository at this point in the history
  • Loading branch information
alexkuzmik committed Mar 26, 2024
1 parent 5473f4c commit 99b0e2c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions src/comet_llm/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ def _extend_comet_ml_config() -> None:
"comet.logging.console": {"type": str, "default": "INFO"},
"comet.raise_exceptions_on_error": {"type": int, "default": 0},
"comet.internal.check_tls_certificate": {"type": bool, "default": True},
"comet.offline": {"type": bool, "default": False},
"comet.offline_folder_path": {"type": str, "default": ".cometllm-runs"},
"comet.online": {"type": bool, "default": True},
"comet.offline_directory": {"type": str, "default": ".cometllm-runs"},
"comet.offline_batch_duration_seconds": {"type": int, "default": 300},
}

Expand Down Expand Up @@ -99,11 +99,11 @@ def tls_verification_enabled() -> bool:


def offline_enabled() -> bool:
return bool(_COMET_ML_CONFIG["comet.offline"])
return not bool(_COMET_ML_CONFIG["comet.online"])


def offline_folder_path() -> str:
return str(_COMET_ML_CONFIG["comet.offline_folder_path"])
def offline_directory() -> str:
return str(_COMET_ML_CONFIG["comet.offline_directory"])


def offline_batch_duration_seconds() -> int:
Expand Down
2 changes: 1 addition & 1 deletion src/comet_llm/message_processing/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

if config.offline_enabled():
MESSAGE_PROCESSOR = offline_message_processor.OfflineMessageProcessor(
offline_directory=config.offline_folder_path(),
offline_directory=config.offline_directory(),
file_usage_duration=config.offline_batch_duration_seconds(),
)
else:
Expand Down

0 comments on commit 99b0e2c

Please sign in to comment.