fix comment

comet-ml · Dec 13, 2024 · 5f81fa0 · 5f81fa0
1 parent 0d0d914
commit 5f81fa0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/apps/opik-backend/src/main/java/com/comet/opik/api/ErrorInfo.java b/apps/opik-backend/src/main/java/com/comet/opik/api/ErrorInfo.java
@@ -1,6 +1,7 @@
 package com.comet.opik.api;
 
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
+import com.fasterxml.jackson.core.type.TypeReference;
 import com.fasterxml.jackson.databind.PropertyNamingStrategies;
 import com.fasterxml.jackson.databind.annotation.JsonNaming;
 import jakarta.validation.constraints.NotBlank;
@@ -13,4 +14,6 @@ public record ErrorInfo(
         @NotBlank String exceptionType,
         String message,
         @NotBlank String traceback) {
+    public static final TypeReference<ErrorInfo> ERROR_INFO_TYPE = new TypeReference<>() {
+    };
 }
diff --git a/apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java b/apps/opik-backend/src/main/java/com/comet/opik/domain/SpanDAO.java
@@ -1,6 +1,5 @@
 package com.comet.opik.domain;
 
-import com.comet.opik.api.ErrorInfo;
 import com.comet.opik.api.ProjectStats;
 import com.comet.opik.api.Span;
 import com.comet.opik.api.SpanSearchCriteria;
@@ -11,7 +10,6 @@
 import com.comet.opik.domain.stats.StatsMapper;
 import com.comet.opik.utils.JsonUtils;
 import com.comet.opik.utils.TemplateUtils;
-import com.fasterxml.jackson.core.type.TypeReference;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.google.common.base.Preconditions;
 import io.opentelemetry.instrumentation.annotations.WithSpan;
@@ -43,6 +41,7 @@
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
+import static com.comet.opik.api.ErrorInfo.ERROR_INFO_TYPE;
 import static com.comet.opik.domain.AsyncContextUtils.bindUserNameAndWorkspaceContextToStream;
 import static com.comet.opik.domain.AsyncContextUtils.bindWorkspaceIdToFlux;
 import static com.comet.opik.domain.AsyncContextUtils.bindWorkspaceIdToMono;
@@ -1089,8 +1088,7 @@ private Publisher<Span> mapToDto(Result result) {
                     .usage(row.get("usage", Map.class))
                     .errorInfo(Optional.ofNullable(row.get("error_info", String.class))
                             .filter(str -> !str.isBlank())
-                            .map(errorInfo -> JsonUtils.readValue(errorInfo, new TypeReference<ErrorInfo>() {
-                            }))
+                            .map(errorInfo -> JsonUtils.readValue(errorInfo, ERROR_INFO_TYPE))
                             .orElse(null))
                     .createdAt(row.get("created_at", Instant.class))
                     .lastUpdatedAt(row.get("last_updated_at", Instant.class))

diff --git a/apps/opik-backend/src/main/java/com/comet/opik/domain/TraceDAO.java b/apps/opik-backend/src/main/java/com/comet/opik/domain/TraceDAO.java
@@ -1,7 +1,6 @@
 package com.comet.opik.domain;
 
 import com.comet.opik.api.BiInformationResponse.BiInformation;
-import com.comet.opik.api.ErrorInfo;
 import com.comet.opik.api.ProjectStats;
 import com.comet.opik.api.Trace;
 import com.comet.opik.api.TraceSearchCriteria;
@@ -12,7 +11,6 @@
 import com.comet.opik.infrastructure.db.TransactionTemplateAsync;
 import com.comet.opik.utils.JsonUtils;
 import com.comet.opik.utils.TemplateUtils;
-import com.fasterxml.jackson.core.type.TypeReference;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.google.common.base.Preconditions;
 import com.google.inject.ImplementedBy;
@@ -42,6 +40,7 @@
 import java.util.UUID;
 import java.util.stream.Collectors;
 
+import static com.comet.opik.api.ErrorInfo.ERROR_INFO_TYPE;
 import static com.comet.opik.api.Trace.TracePage;
 import static com.comet.opik.api.TraceCountResponse.WorkspaceTraceCount;
 import static com.comet.opik.domain.AsyncContextUtils.bindUserNameAndWorkspaceContext;
@@ -929,8 +928,7 @@ private Publisher<Trace> mapToDto(Result result) {
                         : row.get("total_estimated_cost", BigDecimal.class))
                 .errorInfo(Optional.ofNullable(row.get("error_info", String.class))
                         .filter(str -> !str.isBlank())
-                        .map(errorInfo -> JsonUtils.readValue(errorInfo, new TypeReference<ErrorInfo>() {
-                        }))
+                        .map(errorInfo -> JsonUtils.readValue(errorInfo, ERROR_INFO_TYPE))
                         .orElse(null))
                 .createdAt(row.get("created_at", Instant.class))
                 .lastUpdatedAt(row.get("last_updated_at", Instant.class))