Fix calc

comet-ml · Dec 12, 2024 · 1a0a23d · 1a0a23d
1 parent 290fb13
commit 1a0a23d
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 18 deletions.
diff --git a/apps/opik-backend/src/main/java/com/comet/opik/api/Span.java b/apps/opik-backend/src/main/java/com/comet/opik/api/Span.java
@@ -1,6 +1,7 @@
 package com.comet.opik.api;
 
 import com.comet.opik.domain.SpanType;
+import com.comet.opik.utils.DurationUtils;
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.annotation.JsonView;
@@ -14,7 +15,6 @@
 import lombok.Builder;
 
 import java.math.BigDecimal;
-import java.time.Duration;
 import java.time.Instant;
 import java.util.List;
 import java.util.Map;
@@ -75,13 +75,8 @@ public static class Public {
 
     @JsonProperty
     @JsonView({Span.View.Public.class})
-    @Schema(accessMode = Schema.AccessMode.READ_ONLY)
+    @Schema(accessMode = Schema.AccessMode.READ_ONLY, description = "Duration in milliseconds as a decimal number to support sub-millisecond precision")
     public Double duration() {
-        if (endTime == null) {
-            return null;
-        }
-
-        long micros = Duration.between(startTime, endTime).toNanos() / 1_000;
-        return micros / 1_000.0;
+        return DurationUtils.getDurationInSeconds(startTime, endTime);
     }
 }
diff --git a/apps/opik-backend/src/main/java/com/comet/opik/api/Trace.java b/apps/opik-backend/src/main/java/com/comet/opik/api/Trace.java
@@ -1,5 +1,6 @@
 package com.comet.opik.api;
 
+import com.comet.opik.utils.DurationUtils;
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.annotation.JsonView;
@@ -13,7 +14,6 @@
 import lombok.Builder;
 
 import java.math.BigDecimal;
-import java.time.Duration;
 import java.time.Instant;
 import java.util.List;
 import java.util.Map;
@@ -70,13 +70,8 @@ public static class Public {
 
     @JsonProperty
     @JsonView({Span.View.Public.class})
-    @Schema(accessMode = Schema.AccessMode.READ_ONLY)
+    @Schema(accessMode = Schema.AccessMode.READ_ONLY, description = "Duration in milliseconds as a decimal number to support sub-millisecond precision")
     public Double duration() {
-        if (endTime == null) {
-            return null;
-        }
-
-        long micros = Duration.between(startTime, endTime).toNanos() / 1_000;
-        return micros / 1_000.0;
+        return DurationUtils.getDurationInSeconds(startTime, endTime);
     }
 }
diff --git a/apps/opik-backend/src/main/java/com/comet/opik/utils/DurationUtils.java b/apps/opik-backend/src/main/java/com/comet/opik/utils/DurationUtils.java
@@ -0,0 +1,23 @@
+package com.comet.opik.utils;
+
+import lombok.NonNull;
+import lombok.experimental.UtilityClass;
+
+import java.time.Duration;
+import java.time.Instant;
+
+@UtilityClass
+public class DurationUtils {
+
+    public static final Double TIME_UNIT = 1_000.0;
+
+    public static Double getDurationInSeconds(@NonNull Instant startTime, Instant endTime) {
+        if (endTime == null) {
+            return null;
+        }
+
+        long micros = Duration.between(startTime, endTime).toNanos() / TIME_UNIT.longValue();
+        return micros / TIME_UNIT;
+    }
+
+}
diff --git a/apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/SpansResourceTest.java b/apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/SpansResourceTest.java
@@ -2837,8 +2837,6 @@ void getSpansByProject__whenFilterByDuration__thenReturnSpansFiltered(Operator o
                             .value(String.valueOf(duration))
                             .build());
 
-            spans.forEach(span -> log.info("Span: {}", span));
-
             getAndAssertPage(workspaceName, projectName, filters, spans, expectedSpans, unexpectedSpans, apiKey);
         }