Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update entity handling for runtime verb parameters #55

Merged
merged 2 commits into from
Dec 2, 2024
Merged

feat: Update entity handling for runtime verb parameters #55

merged 2 commits into from
Dec 2, 2024

Conversation

jagzmz
Copy link
Contributor

@jagzmz jagzmz commented Nov 17, 2024 •
edited
Loading

Summary of Changes

Update runtime verb parameters in SKLEngine to handle entity IDs and types from the SKLSO data namespace

Technical Details

  • Add SKLSO_DATA_NAMESPACE and SKLSO_PROPERTY_NAMESPACE constants
  • Add replaceTypeAndId function to replace entity @type and @id with sklso:type and sklso:identifier properties
  • Update updateEntityFromVerbArgs, saveEntityOrEntitiesFromVerbArgs, and destroyEntityOrEntitiesFromVerbArgs to call replaceTypeAndId before saving/updating/deleting entities
  • Add .env to .gitignore

Commit History

  • Update runtime verb parameters

@jagzmz jagzmz requested a review from mithyalabs November 17, 2024 15:55
@jagzmz jagzmz merged commit 00ab3b6 into main Dec 2, 2024
6 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithyalabs mithyalabs mithyalabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jagzmz @mithyalabs