Basic Auth and debug flag #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic auth params added
adlerfaulkner
requested changes
Jun 4, 2024
| "quadstore": "13.0.0-alpha.1", | ||
| "quadstore-comunica": "^3.3.0", | ||
| "quadstore": "13.1.1", | ||
| "quadstore-comunica": "^4.3.0", |
There was a problem hiding this comment.
I had some trouble with upgrading comunica so you may have to downgrade if you can't get the CI to pass. I can't remember what it was exactly at the moment but I'll let you know if I find out
There was a problem hiding this comment.
I think I added .nvmrc for the same reason. Can you just use nvm use and then give it a try.
For CI also we might need to look at the node version.
package.json
Outdated
| @@ -93,4 +93,4 @@ | |||
| "peerDependencies": { | |||
| "axios": "^0.27.2" | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
nit: please re-add the newline at the end of the file and setup your linter to use the included eslint rules
adlerfaulkner
requested changes
Jun 6, 2024
src/SklEngine.ts
Outdated
| @@ -4,26 +4,37 @@ import type { | |||
| OpenApiClientConfiguration, | |||
| } from '@comake/openapi-operation-executor'; | |||
| import { OpenApiOperationExecutor } from '@comake/openapi-operation-executor'; | |||
| import { getIdFromNodeObjectIfDefined, type ReferenceNodeObject } from '@comake/rmlmapper-js'; | |||
| import { | |||
There was a problem hiding this comment.
@mithyalabs there's still tons of auto-formatting done in here. Please revert it so that I can focus on meaningful changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quadstoreandquadstore-comunica