Merge pull request #52 from comake/groupBySupport

Group by support
comake · Nov 1, 2024 · 11137bc · 11137bc
2 parents 9769dce + 12c47cf
commit 11137bc
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "@comake/skl-js-engine",
-	"version": "0.22.0",
+	"version": "0.23.0",
 	"description": "Standard Knowledge Language Javascript Engine",
 	"keywords": [
 		"skl",

diff --git a/src/storage/query-adapter/sparql/SparqlQueryBuilder.ts b/src/storage/query-adapter/sparql/SparqlQueryBuilder.ts
@@ -1136,7 +1136,7 @@ export class SparqlQueryBuilder {
       ],
       combinedWhere,
       [], // orders
-      groupVariables, // group by
+      groupVariables.length > 0 ? groupVariables : undefined, // group by
       options.limit,
       options.offset
     );

diff --git a/src/util/SparqlUtil.ts b/src/util/SparqlUtil.ts
@@ -239,7 +239,7 @@ export function createSparqlSelectQuery(
   limit?: number,
   offset?: number,
 ): SelectQuery {
-  let groupings: Grouping[] | undefined = [];
+  let groupings: Grouping[] | undefined;
   if (group) {
     if (Array.isArray(group)) {
       groupings = group.map(g => ensureGrouping(g));