-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Release guide for this fork #258
docs: Release guide for this fork #258
Conversation
UPDATING.md is not needed anymore Signed-off-by: Juan Munoz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, clear steps and easy to follow! Ive added a few suggestions to make the steps a bit more clear.
RELEASING.md
Outdated
|
||
`git fetch upstream` | ||
|
||
3. Create a new release branch from the latest release of open-scd (this could be *upstream/main* if it was just released or the specific commit hash of the release), using a branch name relative to the desired release tag, example: *release_v0_33_0_1* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could maybe specify the git command? Like for example: git checkout *hash* -b release_v0_33_0_1
RELEASING.md
Outdated
|
||
5. Make sure tests are passing, add fixes for breaking changes from **open-scd** | ||
6. Update the version number in your project's `package.json` file. | ||
7. Create a PR from your release branch into *main* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before creating a PR the branch first needs to be merged. Command could be for example: git push --set-upstream origin release_v0_33_0_1
Signed-off-by: Juan Muñoz <[email protected]>
…w-version-of-openscd-from-this-fork
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Closes #255