Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch windows #236

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Watch windows #236

merged 2 commits into from
Nov 17, 2023

Conversation

sake92
Copy link
Collaborator

@sake92 sake92 commented Nov 17, 2023

There are 2 parts to this fix:

  1. the FILE_TREE modifier, which tells Windows to watch the whole folder recursively. This prevents errors when trying to move/rename a folder, since otherwise it locks them and we get errors.. Got this from here https://stackoverflow.com/a/6265860/4496364
  2. preventing dynamic registration of subfolders in the recursiveWatches method

The diff in the test is a bit messed up, there are just a few lines changed.. :/

lefou
lefou approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@sake92 sake92 merged commit 7ab5c0f into com-lihaoyi:main Nov 17, 2023
9 checks passed
@sake92 sake92 deleted the watch-windows branch November 17, 2023 18:29
@lefou lefou added this to the after 0.9.2 milestone Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.3
Development

Successfully merging this pull request may close these issues.
2 participants
@sake92 @lefou