Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show all events on 1 page and improve query time ⚡️ #680

Merged
merged 13 commits into from
Dec 13, 2024

Conversation

ramiAbdou
Copy link
Member

@ramiAbdou ramiAbdou commented Dec 13, 2024

Description ✏️

This PR:

  • Combines the events page into 1 instead of an "Upcoming" and "Past".
  • Consolidates all of the event module into one folder.
  • Fixes performance issues with the listPastEvents and listUpcomingEvents queries by refactoring to use joins instead of subqueries and adds indices on the event_id column in both tables.
  • Redirects requests from /events/upcoming to /events.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Dec 13, 2024
@ramiAbdou ramiAbdou changed the title fix: improve query time and show all events on 1 page ⚡️ feat: show all events on 1 page and improve query time ⚡️ Dec 13, 2024
@ramiAbdou ramiAbdou marked this pull request as ready for review December 13, 2024 15:53
@ramiAbdou ramiAbdou merged commit ce0b8ef into main Dec 13, 2024
1 check passed
@ramiAbdou ramiAbdou deleted the rami/events branch December 13, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant