Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use Slot component instead of getButtonCn 🔄 #672

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Conversation

ramiAbdou
Copy link
Member

Description ✏️

This PR creates a Button.Slot component which uses Radix's utility Slot component to merge props onto the child. This means that we can be more declarative when trying to apply button styling to an anchor element.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Dec 12, 2024
@ramiAbdou ramiAbdou marked this pull request as ready for review December 12, 2024 02:40
@ramiAbdou ramiAbdou merged commit a680975 into main Dec 12, 2024
2 checks passed
@ramiAbdou ramiAbdou deleted the rami/slot branch December 12, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant