Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement delete resource functionality 🕳️👨‍🦯 #615

Merged
merged 9 commits into from
Dec 11, 2024

Conversation

Boris713
Copy link
Contributor

Description ✏️

Closes #261

Describe what this PR does.

  • Adds dropdown menu for selecting delete or copy link
  • Created modal to confirm delete
  • logic to delete item from database
Screenshot 2024-11-11 at 9 38 26 PM Screenshot 2024-11-11 at 9 38 51 PM

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

Copy link
Collaborator

@tomas-salgado tomas-salgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Boris713! I pushed a couple of changes that modify the UI of where we have delete. I changed the location to be within the 'Edit' modal, and I also modified the UI of the deletion confirmation modal. This was all just to match the pattern we use in deleting job offers (so we have consistently throughout the website).
Screenshot 2024-11-30 at 4 29 46 PM
Screenshot 2024-11-30 at 4 29 54 PM

Should be all set for @ramiAbdou, the only thing is I couldn't properly test when we delete resources with attachments (rather than URLs).

@tomas-salgado tomas-salgado added the Ready ✅ This PR is ready for a final review. label Nov 30, 2024
Copy link
Member

@ramiAbdou ramiAbdou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the deletion of attachments, looks good! ✅

@ramiAbdou ramiAbdou merged commit 5ac3541 into colorstackorg:main Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready ✅ This PR is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to delete a resource 🚮
3 participants