-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement delete resource functionality 🕳️👨🦯 #615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Boris713! I pushed a couple of changes that modify the UI of where we have delete. I changed the location to be within the 'Edit' modal, and I also modified the UI of the deletion confirmation modal. This was all just to match the pattern we use in deleting job offers (so we have consistently throughout the website).
Should be all set for @ramiAbdou, the only thing is I couldn't properly test when we delete resources with attachments (rather than URLs).
…ming deletion of resource to match the UI pattern we use for deleting offers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the deletion of attachments, looks good! ✅
Description ✏️
Closes #261
Describe what this PR does.
Type of Change 🐞
Checklist ✅