Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add confirmation that user has searched for duplicate resources ✅ #612

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

AbdulmajeedKabala
Copy link
Contributor

@AbdulmajeedKabala AbdulmajeedKabala commented Nov 11, 2024

Description ✏️

Closes #269

This PR adds a checkbox field above the "Title" field in the form for adding resources.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

Copy link
Collaborator

@tomas-salgado tomas-salgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @AbdulmajeedKabala! This is a very clean implementation. The only change I made is that I removed an empty migration file that was added. This is now good for Rami to take a final look! 🚀

Note for @ramiAbdou: here the Form.Field component is being used, but the issue is since we are adding a checkbox and this field is required, it's making the UI look clustered at the end of the line. We could not use the Form.Field component at all here and make a custom implementation for this case, but this doesn't seem great. Should we modify the Field component to handle this case?
(tl;dr the UI looks clustered)

Screenshot 2024-11-30 at 5 03 39 PM

@tomas-salgado tomas-salgado added the Ready ✅ This PR is ready for a final review. label Nov 30, 2024
@tomas-salgado tomas-salgado changed the title Add confirmation that user has searched for duplicate resources feat: add confirmation that user has searched for duplicate resources Dec 1, 2024
@tomas-salgado tomas-salgado changed the title feat: add confirmation that user has searched for duplicate resources feat: add confirmation that user has searched for duplicate resources ✅ Dec 1, 2024
@ramiAbdou
Copy link
Member

ramiAbdou commented Dec 10, 2024

Should we modify the Field component to handle this case? (tl;dr the UI looks clustered)

We have a Checkbox component, so we'll utilize that:

Screen.Recording.2024-12-10.at.3.04.40.PM.mov

@ramiAbdou ramiAbdou merged commit 91e8005 into colorstackorg:main Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready ✅ This PR is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add confirmation that user has searched for duplicate resources 🔎
3 participants