-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: store member directory profile urls on slack profile 👥 #563
feat: store member directory profile urls on slack profile 👥 #563
Conversation
…github.com/savazques/oyster into feature/add-directory-profile-url-to-slack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @savazques! This was pretty solid, I just changed up the way we did rate limiting to use the RateLimiter function instead of a delay, and integrated environment variables to get the member directory base URL and the Slack field ID for the member directory URL. Rami will take a last look and then this should be good to ship! 🚀
Question for @ramiAbdou: I wonder if we should move this code into a separate file to be run as a script, since adding the member directory URL to Slack profiles is probably just a one-time thing. There's also various console logs printed as part of these functions that make sense when running a script but probably should be removed otherwise. Thoughts? |
…-profile-url-to-slack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @savazques! I made an update so that when a new member joins a Slack workspace, it'll store their directory URL at that point (on top of the backfill script that you developed)!
Yeah I moved it to its own file but honestly we don't have a great way of running scripts currently so there's not much precedent set for that. I'm okay with the logs in the script function, but I removed the logs from the function that updates an individual profile (which is now used when a new members joins the Slack workspace)! |
Description ✏️
Closes #497
Describe what this PR does.
Type of Change 🐞
Checklist ✅