Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: scrap feature-ui in favor of core-ui 🗑️ #23

Merged
merged 7 commits into from
Mar 28, 2024

Conversation

ramiAbdou
Copy link
Member

@ramiAbdou ramiAbdou commented Mar 28, 2024

Description ✏️

Closes #18.

This PR:

  • Moves all remaining components in feature-ui to core-ui.
  • Updates all references to those 4 components in member-profile and admin-dashboard.
  • Scraps the feature-ui package altogether.
  • Updates any relevant documentation.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Mar 28, 2024
@ramiAbdou ramiAbdou linked an issue Mar 28, 2024 that may be closed by this pull request
@ramiAbdou ramiAbdou changed the title refactor: scrap feature-ui in favor of core-ui refactor: scrap feature-ui in favor of core-ui 🗑️ Mar 28, 2024
@ramiAbdou ramiAbdou merged commit f684477 into main Mar 28, 2024
1 check passed
@ramiAbdou ramiAbdou deleted the 18-move-feature-ui-components branch March 28, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move feature-ui components to core and core-ui ➡️
1 participant