-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subproblem partitioning to support covariance estimation for ultra large-scale problem #2882
Open
B1ueber2y
wants to merge
25
commits into
colmap:main
Choose a base branch
from
B1ueber2y:features/subproblem
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+648
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B1ueber2y
changed the title
Subproblem partitioning with BFS to support covariance estimation for extremely large-scale problem
Subproblem partitioning with BFS to support covariance estimation for ultra large-scale problem
Nov 4, 2024
B1ueber2y
changed the title
Subproblem partitioning with BFS to support covariance estimation for ultra large-scale problem
Subproblem partitioning to support covariance estimation for ultra large-scale problem
Nov 4, 2024
I have not had time to look into the details but the title sounds exciting. Independent of the algorithm itself, I would suggest to first converge on a simplified interface. I took a stab at this in this draft PR: #2788. Not sure if this is still the best approach. It was based on a discussion we had about only exposing the option to compute covariances for poses based on fixed points and vice versa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProblemPartitioner
.estimator.UseSubproblemFromSubsetPoseBlocks
andestimator.UseSubproblemFromSubsetImages
.Factorize()
introduced in Faster covariance computation for small blocks #2633)Note that with this update the qvec and tvec for a single image might not be in adjacent blocks in the internal ordering of covariance estimation, and thus the covariance getter by image ids are accordingly updated. The performance should stay unchanged.
This will make estimation of pose covariance for ultra large-scale problem feasible with a reasonable selection of subset pose blocks. One can do covariance estimation in sliding window manner either spatially or temporally with this update.