Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement control panel to configure pas.plugins.oidc #66

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

ericof
Copy link
Member

@ericof ericof commented Dec 6, 2024

Implements #65

@ericof ericof requested review from mamico and erral December 6, 2024 22:40
@ericof ericof merged commit c05ee2f into main Dec 10, 2024
5 checks passed
@ericof ericof deleted the issue-65-controlpanel branch December 10, 2024 02:05
@erral
Copy link
Member

erral commented Dec 10, 2024

This controlpanel only works for the plugin whose name is PLUGIN_ID and we can have more plugins after #48

We should either state that in the control panel or modify the controlpanel to allow modifying the settings on any plugin.

@ericof
Copy link
Member Author

ericof commented Dec 10, 2024

Let's open a new issue for this. I was "kind of aware" this could be an issue, but as I wanted to have this out asap, I decided to not over engineer it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants