added event for creating a user #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erral
requested changes
May 6, 2024
| @@ -215,6 +217,8 @@ def rememberIdentity(self, userinfo): | |||
| # https://bandit.readthedocs.io/en/1.7.4/plugins/b110_try_except_pass.html | |||
| pass | |||
| self._updateUserProperties(user, userinfo) | |||
| if user is not None: | |||
| notify(PrincipalCreated(user)) | |||
There was a problem hiding this comment.
Is notifying this enough? For instance, when a user logs in a Plone site and Plone fires portal_membership's loginUser, this tool notifies either UserInitialLoginEvent or UserLoggedInEvent.
I think that we should be notifying those two events too.
There was a problem hiding this comment.
If I see it correctly, it can also happen that member properties have to be updated with every new login. From this point of view, it definitely makes sense to notifying more events.
|
As this PR seems stale, and @steffenri has a deadline to respect, I created a new PR #58 including the implementation here and the additional events requested by @erral |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explained in #53