fixed plone.protect issue #6 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
doesn't disable CSRF checks like in #5 |
huubbouma
reviewed
Mar 10, 2017
| @@ -29,6 +31,9 @@ class pdfpeekUtilView(BrowserView): | |||
| def process_conversion_queue(self): | |||
| """process the queue. | |||
| """ | |||
| token = createToken() | |||
| self.request.set('_authenticator', token) | |||
|
|
|||
There was a problem hiding this comment.
Wouldn't it be better to disable the csrf protection explicitly instead of adding a generated token to the request? In the end this still circumvents the csrf protection, which is ok, but then I would rather use the IDisableCSRFProtection as it's done in PR #5
There was a problem hiding this comment.
as i am not into that CSRF stuff i wasn't sure if disabling any security feature is a good thing and worked out that solution without changing any protection mechanisms, or touching it ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed by adding token to request