Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Import WalletDefault as used by democode #1633

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

aflock
Copy link
Contributor

@aflock aflock commented Nov 15, 2024

What changed? Why?
On the component demo for onchainkit.xyz, we used <WalletDefault /> without actually importing it. So copy-pasting the code in would fail. Added to fix
(another option would be to use <Wallet />, but since WalletDefault is easier to get started with, left as-is)

Notes to reviewers

How has it been tested?
Ran locally
Before:
image

After:
image

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 7:55pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 7:55pm

Copy link

vercel bot commented Nov 15, 2024

@aflock is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@brendan-defi brendan-defi merged commit 5e11e0d into coinbase:main Nov 15, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants