Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix CLI's npm build #1617

Merged
merged 17 commits into from
Nov 13, 2024
Merged

fix: fix CLI's npm build #1617

merged 17 commits into from
Nov 13, 2024

Conversation

dschlabach
Copy link
Contributor

@dschlabach dschlabach commented Nov 13, 2024

What changed? Why?
Our CLI template has mismatching versions of viem and wagmi from onchainkit, causing type errors and the build to fail. This PR updates the template's package.json to have versions of viem and wagmi that match onchainkit's.

Notes to reviewers

  • Also adds CI check that builds package, runs it, installs deps, and builds the project with npm

How has it been tested?

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 5:57pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 5:57pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 5:57pm

@dschlabach dschlabach merged commit eecb9aa into main Nov 13, 2024
17 checks passed
@dschlabach dschlabach deleted the dms/cli-fix branch November 13, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants