docs: update structure for Wallet docs
#1581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dschlabach
changed the title
Wallet docsWallet docs
alessey
reviewed
Nov 15, 2024
alessey
reviewed
Nov 15, 2024
alessey
reviewed
Nov 15, 2024
site/docs/pages/wallet/wallet.mdx
Outdated
| }, ]} /> | ||
|
|
||
| ### ConnectWallet | ||
| Handles the wallet connection process. Place child components inside to customize the connect button appearance. |
There was a problem hiding this comment.
we need to standardize on what we call the "child components". in other docs we refer to them as subcomponents, and children below references "customized content"
There was a problem hiding this comment.
I am in support of standardizing around the following:
- Components that we ship are subcomponents (e.g. ConnectWallet, NFTMedia, etc)
- children the user passes in are just
children
There was a problem hiding this comment.
In this case though, I'm in favor of removing "Place child components inside...", it feels unnecessary when the children prop is right there in the table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR updates the structure for our documentation to make it easier for developers to scan through available props and sub-components.
Adds:
Notes to reviewers
How has it been tested?