-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Swap Settings SwapProvider #1176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
Zizzamia
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, and I left only one note that could be done as fast-follow.
alessey
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Add
SwapSettings
ComponentThis PR introduces a new
SwapSettings
component, providing a dropdown interface for users to customize slippage settings during swaps. The component is composed of several subcomponents that manage different aspects of the slippage settings.Key changes and additions:
SwapSettings
component with subcomponents:SwapSettingsSlippageDescription
SwapSettingsSlippageInput
SwapSettingsSlippageLayout
SwapSettingsSlippageLabel
SwapSettingsSlippageLayoutBottomSheet
for mobile viewswapSettings
SVG iconSwap
component to include and renderSwapSettings
Functionality:
This enhancement gives users more control over their swap settings while maintaining a clean and intuitive interface.
Recording:
Screen.Recording.2024-08-28.at.12.25.46.PM.mov
Notes to reviewers
see design in Slack
Fast follow PRs
How has it been tested?
locally
Idle states
Hover states
Override state
Responsive