Feature: write status of the build/deployment as a PR comment when using github workflows #1115
+104
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
ddonukis
commented
Oct 18, 2024
| retention-days: 1 | ||
| if-no-files-found: error | ||
|
|
||
| pr-writeback: |
There was a problem hiding this comment.
Using a separate job because jq is not installed in the toolkit container. And to install it need to install curl first.
But jq is pre-installed in the default runner image, so just went with that.
Ideally, I'd bake jq into the toolkit docker image and then we could simplify the workflow a lot. No need to run a separate job, no need to upload/download log files. It'll be fast and simpler.
ddonukis
commented
Oct 25, 2024
| printf 'Toolkit dry run triggered: %s\n\n%s\n%s\n\n```\n%s\n```\n' \ | ||
| "$RUN_LINK" "$B_STATUS" "$DR_STATUS" "$MSG" > pr-comment-body.txt | ||
|
|
||
| gh pr comment $PR_NUMBER -F pr-comment-body.txt 2> pr-comment-error.log |
There was a problem hiding this comment.
this fails if comment body is too long, which also breaks the PR check
preliminary handling is implemented but needs more work and testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the github workflow build template: write status of the build/deployment as a PR comment when using github workflows.
Checklist
_version.py and
pyproject.toml per semantic versioning.