Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom success message for ExtractionPipelineRun #276

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

redzaroslii
Copy link

Modify Extractor base class for success_message option that is passed as an input to ExtractionPipelineRun() when a run is successful

@redzaroslii redzaroslii requested a review from a team as a code owner December 19, 2023 16:31
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #276 (891da15) into master (e5f447f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   78.62%   78.60%   -0.02%     
==========================================
  Files          22       22              
  Lines        1932     1935       +3     
==========================================
+ Hits         1519     1521       +2     
- Misses        413      414       +1     
Files Coverage Δ
cognite/extractorutils/__init__.py 100.00% <100.00%> (ø)
cognite/extractorutils/base.py 48.92% <100.00%> (+0.27%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@einarmo einarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants