Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support InstanceReferences filter for Data Modeling #2081

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

erlendvollset
Copy link
Collaborator

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@erlendvollset erlendvollset requested review from a team as code owners January 6, 2025 12:34
@erlendvollset erlendvollset force-pushed the instance-reference-filter-dm branch 2 times, most recently from 6e8bbf3 to 6545c32 Compare January 6, 2025 12:57
@erlendvollset erlendvollset force-pushed the instance-reference-filter-dm branch from 6545c32 to 0875dc6 Compare January 6, 2025 13:04
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.49%. Comparing base (b040e27) to head (eddb7ce).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2081      +/-   ##
==========================================
- Coverage   90.50%   90.49%   -0.01%     
==========================================
  Files         141      141              
  Lines       22558    22566       +8     
==========================================
+ Hits        20415    20421       +6     
- Misses       2143     2145       +2     
Files with missing lines Coverage Δ
cognite/client/_api/data_modeling/instances.py 88.41% <ø> (+0.23%) ⬆️
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/data_classes/filters.py 95.62% <100.00%> (-0.20%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Contributor

@haakonvt haakonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs/source/filters.rst file needs to be updated

cognite/client/data_classes/filters.py Outdated Show resolved Hide resolved
cognite/client/data_classes/filters.py Outdated Show resolved Hide resolved
@erlendvollset erlendvollset requested a review from a team January 6, 2025 13:48
@erlendvollset erlendvollset enabled auto-merge (squash) January 6, 2025 14:00
@haakonvt haakonvt disabled auto-merge January 6, 2025 14:31
@erlendvollset erlendvollset enabled auto-merge (squash) January 6, 2025 14:41
@erlendvollset erlendvollset merged commit 49c87bd into master Jan 6, 2025
15 checks passed
@erlendvollset erlendvollset deleted the instance-reference-filter-dm branch January 6, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants