Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: support liquid network #52

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Conversation

vincenzopalazzo
Copy link
Contributor

Adding a very basic support for liquid network

@vincenzopalazzo vincenzopalazzo changed the title plugin: support liquid payments plugin: support liquid network Dec 17, 2023
@vincenzopalazzo vincenzopalazzo force-pushed the macros/liquid-support branch 2 times, most recently from 51e62fc to e31ac4d Compare December 17, 2023 00:53
@vincenzopalazzo
Copy link
Contributor Author

looks like that rust bitcoin here is causing problem (from bitcoincore-rpc)

2023-12-17T00:52:03.980Z DEBUG   plugin-folgore_plugin: call get block by height
2023-12-17T00:52:03.980Z INFO    plugin-folgore_plugin: cln request {\"height\":2641160}
2023-12-17T00:52:04.621Z INFO    plugin-folgore_plugin: running into retry logic due a request failing. Time `4` waiting `60` secs
2023-12-17T00:52:04.621Z INFO    plugin-folgore_plugin: we try 4 times the request but the error persist
2023-12-17T00:52:04.622Z UNUSUAL plugin-folgore_plugin: client `esplora` return an error: code: -1, msg: Recovery strategy (TimeoutRety) fails: `code: -1, msg: BitcoinEncoding(Io(Error { kind: UnexpectedEof, message: \"failed to fill whole buffer\" }))`
/home/vincent/github/work/rust-btc/folgore/target/debug/folgore_plugin error: bad response to getrawblockbyheight (bad 'result' field: Parsing '{result:': object does not have member result), response was {"error":{"code":-1,"data":null,"message":"Recovery strategy (TimeoutRety) fails: `code: -1, msg: BitcoinEncoding(Io(Error { kind: UnexpectedEof, message: \"failed to fill whole buffer\" }))`"},"id":"cln:getrawblockbyheight#20","jsonrpc":"2.0"}

@vincenzopalazzo vincenzopalazzo force-pushed the macros/liquid-support branch 3 times, most recently from e1d97ae to 50be8d4 Compare December 29, 2023 00:03
Supporting the liquid network inside the esplora backend
and remove the contraint to required a fallback backend.

Signed-off-by: Vincenzo Palazzo <[email protected]>
@vincenzopalazzo vincenzopalazzo force-pushed the macros/liquid-support branch 2 times, most recently from 7c7224b to 18d643e Compare December 30, 2023 01:26
This commit introduce a simple esplora API that remove the
dependencies over rust-bitcoin and this means that we can
now support liquid.

In addition, support a library that force us to use a specific
types is not a good idea, and due that rust bitcoin is starting
to be a little bit hard to mantain we switch over our implementation.

Signed-off-by: Vincenzo Palazzo <[email protected]>
@vincenzopalazzo vincenzopalazzo marked this pull request as ready for review December 30, 2023 01:26
@vincenzopalazzo
Copy link
Contributor Author

Assuming that this is correct, due that I am able to reproduce the following error on cln ElementsProject/lightning#6955 (comment)

@vincenzopalazzo vincenzopalazzo merged commit 8121176 into main Dec 30, 2023
4 checks passed
@vincenzopalazzo vincenzopalazzo deleted the macros/liquid-support branch December 30, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant