-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coffee disable
and coffee enable
Commands
#240
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added the enabled field in the plugin struct to track plugin status - Plugins are now set as enabled by default upon installation - Modified coffee list to display the enabled status of each plugin - For backward compatibility, assume plugins are enabled if plugin.enabled is None This sets the groundwork for implementing coffee enable and coffee disablecommands Signed-off-by: Tarek <[email protected]>
This commit introduces coffee disable and coffee enable commands, enabling users to toggle plugin status without complete uninstallation. Additionally, it includes the implementation of corresponding methods in CoffeeManager and updates to CLI commands and documentation. Signed-off-by: Tarek <[email protected]>
Signed-off-by: Tarek <[email protected]>
✅ Deploy Preview for coffee-docs canceled.
|
vincenzopalazzo
requested changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are missing test (we can avoid the httpd test btw) for this feature
Signed-off-by: Tarek <[email protected]>
vincenzopalazzo
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
coffee disable
andcoffee enable
commands, allowing users to toggle plugin status without complete uninstallation.The implementation ensures backward compatibility by making the new field "enabled" optional in the plugin struct.
Closes #102
Changes made
disable
andenable
methods forCoffeeManager
coffee enable/disable <plugin_name>
To Do
coffee
andcoffee_httpd
, to be added following ci integration testing is broken #236coffee disable --all
to disable all plugins with a single command