Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add verbose flag to upgrade #217

Merged
merged 1 commit into from
Dec 30, 2023
Merged

feat: add verbose flag to upgrade #217

merged 1 commit into from
Dec 30, 2023

Conversation

royalpinto007
Copy link
Contributor

Created a draft PR for adding verbose flag support to upgrade command.

Issue Reference- #214

@netlify Netlify
Copy link

netlify bot commented Dec 29, 2023 •
edited
Loading

✅ Deploy Preview for coffee-docs canceled.

Name Link
🔨 Latest commit 516f620
🔍 Latest deploy log https://app.netlify.com/sites/coffee-docs/deploys/659069515a104400084666d0

vincenzopalazzo
vincenzopalazzo requested changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass of review

coffee_core/src/coffee.rs Outdated Show resolved Hide resolved
coffee_cmd/src/main.rs Outdated Show resolved Hide resolved
vincenzopalazzo
vincenzopalazzo requested changes Dec 30, 2023
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments, but I did not know why this is not printing the vebose version of the command

coffee_cmd/src/main.rs Outdated Show resolved Hide resolved
coffee_cmd/src/main.rs Outdated Show resolved Hide resolved
coffee_cmd/src/cmd.rs Show resolved Hide resolved
coffee_lib/src/plugin.rs Outdated Show resolved Hide resolved
coffee_core/src/coffee.rs Show resolved Hide resolved
coffee_cmd/src/main.rs Outdated Show resolved Hide resolved
vincenzopalazzo
vincenzopalazzo requested changes Dec 30, 2023
View reviewed changes
coffee_cmd/src/main.rs Outdated Show resolved Hide resolved
@royalpinto007 royalpinto007 force-pushed the verbose-test branch 2 times, most recently from ba1e3b6 to e1c4440 Compare December 30, 2023 16:34
vincenzopalazzo
vincenzopalazzo reviewed Dec 30, 2023
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

You can squash the commit in a single one? there is no reason to keep 4 commits 😄

@royalpinto007
feat: verbose to upgrade
516f620 
feat: add verbose flag to upgrade

fix: lint check

feat: upgrade spinner

fix: minor bugs/comments
@royalpinto007
Copy link
Contributor Author

Done @vincenzopalazzo :)

@vincenzopalazzo vincenzopalazzo merged commit a9a0523 into coffee-tools:master Dec 30, 2023
9 checks passed
@tareknaser tareknaser mentioned this pull request Feb 5, 2024
Closed
@royalpinto007 royalpinto007 deleted the verbose-test branch February 7, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tareknaser tareknaser tareknaser left review comments

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@royalpinto007 @vincenzopalazzo @tareknaser