Merge pull request #412 from JramR7/MAT-57

MAT-57 Fix mobile menu item stories
codypearce · Jun 23, 2020 · 34a6f3b · 34a6f3b
2 parents d00008e + 8ba590d
commit 34a6f3b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/src/Components/Menu/Menu.stories.js b/src/Components/Menu/Menu.stories.js
@@ -123,19 +123,23 @@ export default storiesOf('Components|Menu', module)
               }>
               <MenuItem
                 text={'Menu Item 1'}
+                style={{ paddingHorizontal: '12%' }}
                 onPress={() => store.set({ visibleThree: false })}
               />
               <MenuItem
                 text={'Menu Item 2'}
+                style={{ paddingHorizontal: '12%' }}
                 onPress={() => store.set({ visibleThree: false })}
               />
               <MenuItem
                 text={'Menu Item 3'}
+                style={{ paddingHorizontal: '12%' }}
                 disabled
                 onPress={() => store.set({ visibleThree: false })}
               />
               <MenuItem
                 text={'Menu Item 4'}
+                style={{ paddingHorizontal: '12%' }}
                 onPress={() => store.set({ visibleThree: false })}
               />
             </Menu>

diff --git a/src/Components/Menu/MenuItem/MenuItem.stories.js b/src/Components/Menu/MenuItem/MenuItem.stories.js
@@ -13,7 +13,7 @@ export default storiesOf('Components|Menu/MenuItem', module)
     <Container>
       <Header title={'Menu Item'} />
 
-      <Paper radius={6} style={{ width: 324, flex: 1 }}>
+      <Paper radius={6} style={{ width: 324 }}>
         <MenuItem text="Menu Item 1" />
         <MenuItem text="Menu Item 2" />
         <Divider />
@@ -26,7 +26,7 @@ export default storiesOf('Components|Menu/MenuItem', module)
     <Container>
       <Header title={'Menu icons'} />
 
-      <Paper radius={6} style={{ width: 324, flex: 1 }}>
+      <Paper radius={6} style={{ width: 324 }}>
         <MenuItem
           text={'Preview'}
           icon={<Icon name={'assignment-turned-in'} />}
@@ -43,7 +43,7 @@ export default storiesOf('Components|Menu/MenuItem', module)
     <Container>
       <Header title={'Menu keyboard commands'} />
 
-      <Paper radius={6} style={{ width: 324, flex: 1 }}>
+      <Paper radius={6} style={{ width: 324 }}>
         <MenuItem
           text={'Cut'}
           icon={<Icon name={'content-cut'} />}

diff --git a/src/Components/Menu/MenuItem/MenuItem.styles.js b/src/Components/Menu/MenuItem/MenuItem.styles.js
@@ -2,15 +2,13 @@ import { StyleSheet } from 'react-native';
 
 const styles = StyleSheet.create({
   container: {
-    height: 48,
     minHeight: 32,
     width: 324,
     minWidth: 124,
-    flex: 1,
     alignItems: 'center',
     flexDirection: 'row',
-    paddingHorizontal: 24,
     paddingVertical: 12,
+    paddingHorizontal: 24,
   },
   title: {
     fontSize: 16,

diff --git a/src/Components/Menu/MenuItem/__snapshots__/MenuItem.test.js.snap b/src/Components/Menu/MenuItem/__snapshots__/MenuItem.test.js.snap
@@ -34,9 +34,7 @@ exports[`MenuItem Renders 1`] = `
       Object {
         "alignItems": "center",
         "backgroundColor": null,
-        "flex": 1,
         "flexDirection": "row",
-        "height": 48,
         "minHeight": 32,
         "minWidth": 124,
         "paddingHorizontal": 24,