Add checkbox component #204
Open
+103
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e11sy
reviewed
Jun 10, 2024
e11sy
reviewed
Jun 10, 2024
| @@ -0,0 +1,99 @@ | |||
| <template> | |||
| <div | |||
| :class="[$style.checkbox, disabled ? $style[`checkbox--disabled`] : '', checkboxValue ? $style[`checkbox--on`] : '']" | |||
There was a problem hiding this comment.
Suggested change
| :class="[$style.checkbox, disabled ? $style[`checkbox--disabled`] : '', checkboxValue ? $style[`checkbox--on`] : '']" | |
| :class="[$style.checkbox, disabled && $style[`checkbox--disabled`], checkboxValue && $style[`checkbox--on`]]" |
| <template> | ||
| <div | ||
| :class="[$style.checkbox, disabled ? $style[`checkbox--disabled`] : '', checkboxValue ? $style[`checkbox--on`] : '']" | ||
| v-on="disabled === false ? { click: changeValue } : {}" |
There was a problem hiding this comment.
vue has @ as v-on shortcut e.g. @click
elizachi
reviewed
Jun 10, 2024
There was a problem hiding this comment.
Please add checkbox to the Playground for testing
| fill="none" | ||
| > | ||
| <path | ||
| d="M5.99998 9.5L8.8823 12.6705C8.96165 12.7578 9.09892 12.7578 9.17828 12.6705L14.3333 7" |
There was a problem hiding this comment.
Seems hardcoded, is there other ways to solve it?
There was a problem hiding this comment.
can be imported from codex the icons package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new checkbox component according to the style