Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dirty way of setting what the result should be AFTER the spinni… #92

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

travisryan
Copy link

@travisryan travisryan commented Jun 1, 2023

created a dirty way of being able to start the spinning and then set the result later. After running the setTo function, it basically restarts the spinning 3 seconds in (so the slow rampup won't be done again) and then finishes with the new result. I'd love to see this done in a better way.

@travisryan
Copy link
Author

Ok figured out how to run two of them at the same time. Nevermind that part...

… to minimize the processing by non-hardware accelerated browsers such as Safari and iOS
@travisryan
Copy link
Author

Added the option to have noBlur for browsers without hardware acceleration. Must be specified on the start of the program.

@coderitual
Copy link
Owner

coderitual commented Jun 3, 2023

Hey @travisryan , First of all Thanks for the effort! Unfortunately the code quality need to be significantly improved before we can go further.

please follow those guidelines:

  • code changes should be related to the PR title and description (so no extension to other parts)
  • please keep high coding standards in examples (no inline js on DOM etc)
  • Don’t leave unnecessary comments
  • Don’t leave console logs (also commented ones)
  • If there is an api change, it should be documented in readme and the best another example should be created (instead of changing the default one)
  • Let’s rethink public api (startFinish sounds vague )

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants