feat: create tiertemplaterevision for each tiertemplate #1061
Conversation
mfrancisc
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan and
ranakan19
as code owners
# Conflicts: # testsupport/init.go
|
seems like some infra/flaky issue: |
|
/retest |
|
infra issues: /retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metlos, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| // But since the creation of a TTR could be very quick and could trigger another reconcile of the NSTemplateTier before the status is actually updated with the reference, | ||
| // this might generate some copies of the TTRs. This is not a problem in production since the cleanup mechanism of TTRs will remove the extra ones but could cause some flakiness with the test, | ||
| // thus we assert the number of TTRs doesn't exceed the double of the expected number. | ||
| assert.LessOrEqual(t, len(objs.Items), 6) |
There was a problem hiding this comment.
I guess that you can also use the len of TemplateRef from tiers.GetTemplateRefs(t, hostAwait, "ttr").Flatten(), right?
Just in case the number of templateRefs changes in the base1ns tier
There was a problem hiding this comment.
did you meant len(tiers.GetTemplateRefs(t, hostAwait, "ttr").Flatten())*2 ? because it can have less or equal double the number of TTRs .
# Conflicts: # testsupport/wait/host.go
|
|
/retest |
1 similar comment
|
/retest |
E2e tests for: codeready-toolchain/host-operator#1103
Jira: https://issues.redhat.com/browse/KUBESAW-146