KUBESAW-250: Fixing the linter error Linter for v1.63.1 #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Feny Mehta <[email protected]>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19 and
mfrancisc
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #444 +/- ##
=======================================
Coverage 78.23% 78.23%
=======================================
Files 49 49
Lines 2444 2444
=======================================
Hits 1912 1912
Misses 478 478
Partials 54 54
|
MatousJobanek
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Looks good, but why this cannot be part of the same PR? #442 is there any reason for creating a separate one?
|
it can be, i will close this and add these changes to 442 |
|
Closing in favour of #442 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be upgrading to golangci-lint version 1.63.3 . This PR is to fix the linter error which were caught as a result of upgrading the linter
Related PR -