Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LabelsAndGenerationPredicate for ToolchainClusterCache controller #437

Conversation

rajivnathan
Copy link
Contributor

@rajivnathan rajivnathan commented Dec 10, 2024

Use LabelsAndGenerationPredicate for ToolchainClusterCache controller to prevent it from reconciling unnecessarily. It's especially relevant since the health checker was included in the ToolchainCluster controller: https://github.com/codeready-toolchain/member-operator/blob/50180a07ca25f97123bf4cc614e801b542beb6cb/main.go#L231 which triggers ToolchainConfig status updates every 10 seconds.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.23%. Comparing base (a6a8525) to head (4a74816).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...nclustercache/toolchaincluster_cache_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   78.23%   78.23%           
=======================================
  Files          49       49           
  Lines        2444     2444           
=======================================
  Hits         1912     1912           
  Misses        478      478           
  Partials       54       54           
Files with missing lines Coverage Δ
...nclustercache/toolchaincluster_cache_controller.go 48.14% <0.00%> (ø)

Copy link
Contributor

@ranakan19 ranakan19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!
Great catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants