-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use LabelsAndGenerationPredicate for ToolchainClusterCache controller #437
Use LabelsAndGenerationPredicate for ToolchainClusterCache controller #437
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #437 +/- ##
=======================================
Coverage 78.23% 78.23%
=======================================
Files 49 49
Lines 2444 2444
=======================================
Hits 1912 1912
Misses 478 478
Partials 54 54
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
Great catch!
…ntroller (codeready-toolchain#437)" This reverts commit 463b623.
Use LabelsAndGenerationPredicate for ToolchainClusterCache controller to prevent it from reconciling unnecessarily. It's especially relevant since the health checker was included in the ToolchainCluster controller: https://github.com/codeready-toolchain/member-operator/blob/50180a07ca25f97123bf4cc614e801b542beb6cb/main.go#L231 which triggers ToolchainConfig status updates every 10 seconds.